fix: show the full description of space permissions - #4976
Conversation
|
|
a823364 to
b49c29d
Compare
|
Hi @retransmit! Thanks for opening this PR! 🙌🏻 I will take of the CR as soon as possible. Stay tuned! |
joragua
left a comment
joragua
left a comment
There was a problem hiding this comment.
Good job @retransmit! 💯 Some comments here about the code:
NOTE: We usually have one commit for the calens entry with the message chore: add calens file. In this PR, you've included the changelog info in the fix commit. Could you split it into two separate commits? Thanks in advance!
The description of a role in the space member permissions list was capped at two lines with a middle ellipsis. Android only applies a middle ellipsis to single-line text, so longer descriptions such as the one for "Can manage" were silently cut after the second line. The description now has room for four lines and uses an end ellipsis, which Android does apply to multi-line text, so anything longer is visibly truncated instead of hidden. Signed-off-by: Lennox <parththale02@gmail.com>
Signed-off-by: Lennox <parththale02@gmail.com>
b49c29d to
5edea00
Compare
|
Addressed all three points: history is now a |
|
Basic checks performed over the solution, everything ✅ Thanks for the contribution @retransmit, will be part of the following release! Approved |
4 participants
Related Issues
App: #4968
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required) -> not required for this fixDescription
The role description in the space member permissions list was capped at two lines with
ellipsize="middle". Android only applies a middle ellipsis to single-line text, so the third line of longer descriptions such as "Can manage" was silently hidden.The description now has room for four lines and uses
ellipsize="end", which Android does apply to multi-line text, so anything longer is visibly truncated instead of hidden.QA
Before / after renderings of the three roles at 360dp on an Android 15 emulator attached below.